Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat consistency error documentation #8815

Merged
merged 36 commits into from
Jan 20, 2025
Merged

Reformat consistency error documentation #8815

merged 36 commits into from
Jan 20, 2025

Conversation

Yiyun333
Copy link
Collaborator

No description provided.

@Yiyun333 Yiyun333 self-assigned this Dec 20, 2024
MariaShaposhnikova
MariaShaposhnikova reviewed Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@MariaShaposhnikova MariaShaposhnikova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Yiyun,
Looks good, I suggested getting rid of the future tense and some improvements.

content/en/docs/refguide/modeling/consistency-errors/consistency-errors-navigation.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/consistency-errors/consistency-errors-navigation.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/consistency-errors/consistency-errors-navigation.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/consistency-errors/consistency-errors-navigation.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/consistency-errors/consistency-errors-pages.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/consistency-errors/consistency-errors-pages.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/consistency-errors/consistency-errors-pages.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/consistency-errors/consistency-errors-pages.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/consistency-errors/consistency-errors-pages.md Outdated Show resolved Hide resolved
content/en/docs/refguide/modeling/consistency-errors/consistency-errors-pages.md Outdated Show resolved Hide resolved
Yiyun333 and others added 22 commits December 30, 2024 11:34
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
439d834 
…cy-errors-navigation.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
c5d86d3 
…cy-errors-navigation.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
b125579 
…cy-errors-navigation.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
dbde3fe 
…cy-errors-navigation.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
a6e4819 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
7523a7b 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
fd0ed9d 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
07333ad 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
451a508 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
3e07264 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
084615c 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
d9f7fa4 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
bf2914d 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
31e668e 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
c3fdefd 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
a98673d 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
3f37da5 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
c5ee842 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
1e94d39 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
76ae6fc 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
991c6b2 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
4938c50 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
Yiyun333 and others added 10 commits December 30, 2024 11:38
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
a9e40cd 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
739de4a 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
7f169e4 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
519b72d 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
306bd33 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
7fd788b 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
96583ef 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
41d7354 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333 @MariaShaposhnikova
Update content/en/docs/refguide/modeling/consistency-errors/consisten…
8992fba 
…cy-errors-pages.md

Co-authored-by: Maria Shaposhnikova <[email protected]>
@Yiyun333
Address Maria's feedback and proofread
39dfe5b
@MariaShaposhnikova
Copy link
Collaborator

Hi Yiyun, implemented changes look good to me!

@Yiyun333
Copy link
Collaborator Author

Yiyun333 commented Dec 31, 2024 •
edited
Loading

Hi Yiyun, implemented changes look good to me!

Hi Maria, thanks a lot for the review!

@Yiyun333 Yiyun333 merged commit e9359bf into development Jan 20, 2025
2 checks passed
@Yiyun333 Yiyun333 deleted the yl-consistency-error-documentation-rewrite branch January 20, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariaShaposhnikova MariaShaposhnikova MariaShaposhnikova left review comments

Assignees

@Yiyun333 Yiyun333

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yiyun333 @MariaShaposhnikova